Summary: | Use [Supplemental] IDL in WebSocket | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore Misc. | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, dominicc, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 72138 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2011-12-08 20:20:35 PST
Created attachment 118526 [details]
Patch
Comment on attachment 118526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118526&action=review > Source/WebCore/websockets/DOMWindowWebSocket.idl:37 > + attribute CloseEventConstructor CloseEvent; Is CloseEvent specific to WebSockets? I guess it is! (In reply to comment #2) > (From update of attachment 118526 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118526&action=review > > > Source/WebCore/websockets/DOMWindowWebSocket.idl:37 > > + attribute CloseEventConstructor CloseEvent; > > Is CloseEvent specific to WebSockets? I guess it is! Yes, it is! http://dev.w3.org/html5/websockets/#closeevent We should do more build system integration. I can help. I'll try to do the Mac build tomorrow. (In reply to comment #4) > We should do more build system integration. I can help. I'll try to do the Mac build tomorrow. What do you mean by "more build system integration"? After this patch is landed, I am planning to change build flows of all platforms as follows: [1] Make a change on DerivedSources.make. (for Mac) [2] Make a change on GNUmakefile.am and bindings/gobject/GNUmakefile.am. (for GTK) [3] Make a change on DerivedSources.pri. (for Qt) [4] Make a change on WebCore.vcproj/MigrateScripts and WebCore.vcproj/WebCore.vcproj. (for Win) [5] Make a change on UseJSC.cmake, UseV8.cmake and PlatformBlackBerry.cmake. (for Efl, WinCE and BlackBerry) Since ENABLE_WEBSOCKET is enabled on all platforms, I hope that now we can confirm if our build flow change is correct or not. Sounds great. Comment on attachment 118526 [details] Patch Attachment 118526 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10833373 Created attachment 118726 [details]
rebased patch for commit
Comment on attachment 118726 [details] rebased patch for commit Clearing flags on attachment: 118726 Committed r102558: <http://trac.webkit.org/changeset/102558> Reverted r102558 for reason: clobber build failure Committed r102571: <http://trac.webkit.org/changeset/102571> Comment on attachment 118726 [details] rebased patch for commit Clearing flags on attachment: 118726 Committed r102774: <http://trac.webkit.org/changeset/102774> |