Bug 74150

Summary: chromium port - remove nacl hack in DEPS and gyp_webkit
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: noel.gordon, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
merge to r102474
none
merge to r102718 none

Dirk Pranke
Reported 2011-12-08 17:49:56 PST
chromium port - remove nacl hack in DEPS/gyp_webkit
Attachments
Patch (2.17 KB, patch)
2011-12-08 17:50 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r102474 (2.18 KB, patch)
2011-12-09 14:20 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r102718 (2.14 KB, patch)
2011-12-13 16:26 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-12-08 17:50:47 PST
Created attachment 118503 [details] Patch
noel gordon
Comment 2 2011-12-09 03:31:47 PST
SGTM.
Tony Chang
Comment 3 2011-12-09 09:54:58 PST
Comment on attachment 118503 [details] Patch I would feel safer about this patch if it passed on the ews bot (or land it with the cq).
Dirk Pranke
Comment 4 2011-12-09 14:20:57 PST
Created attachment 118638 [details] merge to r102474
Dirk Pranke
Comment 5 2011-12-09 14:21:33 PST
someone rolled the DEPS in the meantime and that caused a merge conflict ... I've updated the patch and resubmitted it to EWS.
Dirk Pranke
Comment 6 2011-12-13 16:26:00 PST
Created attachment 119104 [details] merge to r102718
Tony Chang
Comment 7 2011-12-13 16:47:14 PST
Comment on attachment 119104 [details] merge to r102718 Still seems fine.
noel gordon
Comment 8 2011-12-13 17:05:21 PST
Assuming the affected ews are happy.
Dirk Pranke
Comment 9 2011-12-13 18:32:52 PST
Comment on attachment 119104 [details] merge to r102718 Clearing flags on attachment: 119104 Committed r102727: <http://trac.webkit.org/changeset/102727>
Dirk Pranke
Comment 10 2011-12-13 18:32:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.