Summary: | [Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Reveman <reveman> | ||||||||||
Component: | WebCore Misc. | Assignee: | David Reveman <reveman> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alokp, dglazkov, fishd, jamesr, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 74017 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
David Reveman
2011-12-08 13:52:58 PST
Created attachment 118466 [details]
Patch
Created attachment 118581 [details]
Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Comment on attachment 118581 [details] Patch Attachment 118581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10834384 Comment on attachment 118581 [details]
Patch
Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const':
Source/WebKit/chromium/webkit/glue/webpreferences.cc:283: error: 'class WebKit::WebSettings' has no member named 'setAcceleratedDrawingEnabled'
make: *** [out/Release/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1
make: *** Waiting for unfinished jobs....
(In reply to comment #5) > (From update of attachment 118581 [details]) > Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': > Source/WebKit/chromium/webkit/glue/webpreferences.cc:283: error: 'class WebKit::WebSettings' has no member named 'setAcceleratedDrawingEnabled' > make: *** [out/Release/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1 > make: *** Waiting for unfinished jobs.... This build failure was expected until this CL landed: http://codereview.chromium.org/8771056 It should be safe to land this patch now. Chromium has been using the new API for some time now. Created attachment 120647 [details]
Patch
Created attachment 121152 [details]
Patch
Comment on attachment 121152 [details]
Patch
R=me, there aren't any callers
Comment on attachment 121152 [details] Patch Clearing flags on attachment: 121152 Committed r104149: <http://trac.webkit.org/changeset/104149> All reviewed patches have been landed. Closing bug. |