Bug 74125

Summary:

[Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API.

Product:

WebKit

Reporter:

David Reveman <reveman>

Component:

WebCore Misc.

Assignee:

David Reveman <reveman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alokp, dglazkov, fishd, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

74017

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

David Reveman

Reported 2011-12-08 13:52:58 PST

WebSettings::setAcceleratedDrawingEnabled should be removed once chromium is not depending on it anymore.

Attachments
Patch (1.99 KB, patch) 2011-12-08 14:09 PST, David Reveman	no flags	Details Formatted Diff Diff
Patch (2.97 KB, patch) 2011-12-09 08:16 PST, David Reveman	no flags	Details Formatted Diff Diff
Patch (2.98 KB, patch) 2011-12-28 03:18 PST, David Reveman	no flags	Details Formatted Diff Diff
Patch (3.05 KB, patch) 2012-01-04 14:20 PST, David Reveman	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

David Reveman

Comment 1 2011-12-08 14:09:25 PST

Created attachment 118466 [details] Patch

David Reveman

Comment 2 2011-12-09 08:16:48 PST

Created attachment 118581 [details] Patch

WebKit Review Bot

Comment 3 2011-12-09 08:18:55 PST

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

WebKit Review Bot

Comment 4 2011-12-09 17:19:15 PST

Comment on attachment 118581 [details] Patch Attachment 118581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10834384

Eric Seidel (no email)

Comment 5 2011-12-21 15:04:09 PST

Comment on attachment 118581 [details] Patch Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': Source/WebKit/chromium/webkit/glue/webpreferences.cc:283: error: 'class WebKit::WebSettings' has no member named 'setAcceleratedDrawingEnabled' make: *** [out/Release/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1 make: *** Waiting for unfinished jobs....

David Reveman

Comment 6 2011-12-28 03:15:40 PST

(In reply to comment #5) > (From update of attachment 118581 [details]) > Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': > Source/WebKit/chromium/webkit/glue/webpreferences.cc:283: error: 'class WebKit::WebSettings' has no member named 'setAcceleratedDrawingEnabled' > make: *** [out/Release/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1 > make: *** Waiting for unfinished jobs.... This build failure was expected until this CL landed: http://codereview.chromium.org/8771056 It should be safe to land this patch now. Chromium has been using the new API for some time now.

David Reveman

Comment 7 2011-12-28 03:18:38 PST

Created attachment 120647 [details] Patch

David Reveman

Comment 8 2012-01-04 14:20:30 PST

Created attachment 121152 [details] Patch

James Robinson

Comment 9 2012-01-04 15:02:17 PST

Comment on attachment 121152 [details] Patch R=me, there aren't any callers

WebKit Review Bot

Comment 10 2012-01-05 06:02:50 PST

Comment on attachment 121152 [details] Patch Clearing flags on attachment: 121152 Committed r104149: <http://trac.webkit.org/changeset/104149>

WebKit Review Bot

Comment 11 2012-01-05 06:02:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.