Summary: | Use bitfield for bool data members in BitmapImage. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||||||
Component: | WebCore Misc. | Assignee: | Yongjun Zhang <yongjun_zhang> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | webkit.review.bot, yongjun_zhang | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Yongjun Zhang
2011-12-08 10:19:32 PST
Created attachment 118418 [details]
Use bitfield for bool data members in BitmapImage and FrameData.
Attachment 118418 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/BitmapImage.h:283: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/graphics/BitmapImage.h:286: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/graphics/BitmapImage.h:288: One space before end of line comments [whitespace/comments] [5]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 118418 [details] Use bitfield for bool data members in BitmapImage and FrameData. Attachment 118418 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10809306 Created attachment 118422 [details]
Fix style issue.
Comment on attachment 118422 [details] Fix style issue. Attachment 118422 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10797312 Created attachment 118447 [details]
Take 3, fix Qt build breakage.
Comment on attachment 118447 [details] Take 3, fix Qt build breakage. View in context: https://bugs.webkit.org/attachment.cgi?id=118447&action=review > Source/WebCore/platform/graphics/BitmapImage.h:92 > + bool m_haveMetadata:1; > + bool m_isComplete:1; > + bool m_hasAlpha:1; Our normal style is to put spaces around the colons. Created attachment 118465 [details]
Fix minor style issue, adding space around the colons.
Comment on attachment 118465 [details] Fix minor style issue, adding space around the colons. Clearing flags on attachment: 118465 Committed r102404: <http://trac.webkit.org/changeset/102404> All reviewed patches have been landed. Closing bug. |