Bug 7409

Summary:

Some minor fixes to http tests

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch	eric: review-
proposed patch	none
followup patch	none
followup patch	eric: review+

Alexey Proskuryakov

Reported 2006-02-21 13:19:34 PST

The attached patch has several fixes for http tests: - added a favicon.ico, to prevent errors in error_log; - removed an unused variable from perl scripts; - create the httpd logs in /tmp/layout-test-results, not /tmp/WebKit

Attachments
proposed patch (2.35 KB, patch) 2006-02-21 13:20 PST, Alexey Proskuryakov	eric: review-	Details Formatted Diff Diff
proposed patch (3.66 KB, patch) 2006-02-21 21:44 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
followup patch (1.24 KB, patch) 2006-02-22 10:41 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
followup patch (1.14 KB, patch) 2006-02-22 13:37 PST, Alexey Proskuryakov	eric: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2006-02-21 13:20:26 PST

Created attachment 6648 [details] proposed patch

Eric Seidel (no email)

Comment 2 2006-02-21 13:23:19 PST

Comment on attachment 6648 [details] proposed patch Unfortunately /tmp/layout-test-results/ is of little more use to the buildbot than /tmp/WebKit/ That path really should respect the --results-directory flag on run-webkit-tests.

Eric Seidel (no email)

Comment 3 2006-02-21 13:24:22 PST

Comment on attachment 6648 [details] proposed patch The rest of the patch looks fine though.

Alexey Proskuryakov

Comment 4 2006-02-21 21:44:55 PST

Created attachment 6657 [details] proposed patch

Darin Adler

Comment 5 2006-02-21 21:55:38 PST

Comment on attachment 6657 [details] proposed patch Looks fine. Will this fix the buildbot?

Darin Adler

Comment 6 2006-02-21 21:55:39 PST

Comment on attachment 6657 [details] proposed patch Looks fine. Will this fix the buildbot?

Alexey Proskuryakov

Comment 7 2006-02-21 22:09:13 PST

This doesn't fix the buildbot, unfortunately.

Alexey Proskuryakov

Comment 8 2006-02-21 22:30:34 PST

Not only this doesn't fix the buildbot, but it breaks it further - turns out that the results directory is passed by a relative path there: --results-directory layout-test-results For Apache, this means /usr/layout-test-results. I'll need to add support for relative paths. Clearing the review+ flag from the landed patch.

Eric Seidel (no email)

Comment 9 2006-02-22 10:30:05 PST

Comment on attachment 6657 [details] proposed patch Looks great. r=me.

Eric Seidel (no email)

Comment 10 2006-02-22 10:30:49 PST

Comment on attachment 6657 [details] proposed patch Bah, now reading the comments in the bug, clearing flag.

Alexey Proskuryakov

Comment 11 2006-02-22 10:41:15 PST

Created attachment 6668 [details] followup patch Hopefully, this will finally put Apache log files to the right directory...

Alexey Proskuryakov

Comment 12 2006-02-22 13:37:33 PST

Created attachment 6671 [details] followup patch

Eric Seidel (no email)

Comment 13 2006-02-22 15:07:46 PST

Comment on attachment 6671 [details] followup patch Looks great! r=me.

Note You need to log in before you can comment on or make changes to this bug.