Bug 74040 – Fails to build QtWebKit on QNX

• Component: WebKit Qt
• Status: RESOLVED INVALID

When building QtWebkit on QNX, we get compilation failures.
Most of them are related to include files.

Created attachment 118321 [details]
patch

[WebKit Review Bot]

Attachment 118321 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/MathExtras.h:61:  "math.h" already included at Source/JavaScriptCore/wtf/MathExtras.h:57  [build/include] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 118322 [details]
patch

[Simon Hausmann]

Comment on attachment 118321 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118321&action=review

> Source/JavaScriptCore/wtf/MathExtras.h:53
> +#if OS(QNX)
> +#include <math.h>
> +#endif

This was already fixed in r101041 by Daniel.

> Source/WebCore/platform/network/MIMESniffing.cpp:28
> +#if OS(QNX)
> +#include <string.h>
> +#endif

What about replacing #include <cstring> with #include <string.h> without any #ifdef?

[Milian Wolff]

Created attachment 147326 [details]
Patch

[Milian Wolff]

Hey there,

using the patch you see above I managed to built Qt5 QtWebKit for QNX6 using the bbndk 2.0.1.

This also requires a patch to use the new Qt5 plugin system but that is apparently in the pipeline according to bbandix in #qtwebkit on IRC.

I have not yet managed to test the functionality of qtwebkit on a QNX6 device yet, but will do that now.

[Milian Wolff]

The above patch needs to be changed to take the discussion from bug 77013 into account.

[Early Warning System Bot]

Comment on attachment 147326 [details]
Patch

Attachment 147326 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12947827

[Milian Wolff]

Created attachment 147336 [details]
Patch

[Milian Wolff]

Created attachment 147345 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 147345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review

> Source/WTF/wtf/DisallowCType.h:43
> +// this breaks compilation of <QFontDatabase>, at least, so turn it off for now
> +// Also generates errors on wx on Windows and QNX, because these functions
> +// are used from wx and QNX headers.
> +#if !PLATFORM(QT) && !PLATFORM(WX) && !OS(QNX)

Add bug number?

[Milian Wolff]

Well as you can see I just moved this comment from one place where it was already used to the more central one in DisallowCType.h. If you want, I can of course link to this bug report here, is that what you had in mind? If so, I'll update the patch.

Cheers

[Simon Hausmann]

Comment on attachment 147345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review

> Tools/ChangeLog:13
> +        * WebKitTestRunner/EventSenderProxy.h:
> +        * WebKitTestRunner/PlatformWebView.h:
> +        * WebKitTestRunner/TestController.cpp:
> +        * WebKitTestRunner/TestController.h:
> +        * WebKitTestRunner/TestInvocation.cpp:
> +        * WebKitTestRunner/qt/TestControllerQt.cpp:

For portability fixes it really helps if the changelog explains why certain things are done, especially for changes that don't come with a comment in the source code. It may seem obvious to you as you are currently working on this, but in three months it won't be obvious anymore.

[Simon Hausmann]

Comment on attachment 147345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review

This is going to need another iteration, I'm missing explanations (either in this bug or in the ChangeLog) as to why certain changes were made.

>> Source/WTF/wtf/DisallowCType.h:43
>> +#if !PLATFORM(QT) && !PLATFORM(WX) && !OS(QNX)
> 
> Add bug number?

Can you explain why you're moving the code block from config.h into this file?

> Source/WTF/wtf/Platform.h:493
> +#if OS(QNX) || PLATFORM(BLACKBERRY)
> +#define USE_SYSTEM_MALLOC 1
> +#endif

what's the difference between OS(QNX) and PLATFORM(BLACKBERRY)? Does the latter also include the non-QNX based blackberry platforms?

[Antonio Gomes]

Comment on attachment 147345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review

>> Source/WTF/wtf/Platform.h:493
>> +#endif
> 
> what's the difference between OS(QNX) and PLATFORM(BLACKBERRY)? Does the latter also include the non-QNX based blackberry platforms?

Not for now, Simon.

[Milian Wolff]

I'll now try to rebase this patch against current master and add comments wherever needed and try to answer the questions here as well. Furthermore, I'll try to split the issues into smaller bug reports and use this one as a master bug, hope that is OK.

[Milian Wolff]

QtWebKit for QNX should now build properly, thanks for the help everyone.

I'll now try to get it actually working :)

[Milian Wolff]

Reopening, as QtWebKit is again failing to build without manual patches. I'll open more child bugs again to track each issue separately.