| Summary: | [Qt] Fix compilation with newly separated Qt 5 QtQuick module | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ossy, webkit.review.bot, zoltan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Hausmann
2011-12-07 01:50:52 PST
(I'm working on this, in case it wasn't obvious :) Created attachment 118193 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
Ossy, this is landing material for Friday :) Attachment 118193 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1
Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:25: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 118194 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
Comment on attachment 118194 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
This will land friday?
Fixed patch landed in http://trac.webkit.org/changeset/102445 |