Bug 73990

Summary: [Qt] Fix compilation with newly separated Qt 5 QtQuick module
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
none
[Qt] Fix compilation with newly separated Qt 5 QtQuick module none

Description Simon Hausmann 2011-12-07 01:50:52 PST
Latest qtdeclarative separates the QDeclarative* classes from the QQuick* classes by separating the latter out into a separate module. We need to adjust our sources to accommodate this.
Comment 1 Simon Hausmann 2011-12-07 01:51:03 PST
(I'm working on this, in case it wasn't obvious :)
Comment 2 Simon Hausmann 2011-12-07 02:27:51 PST
Created attachment 118193 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
Comment 3 Simon Hausmann 2011-12-07 02:28:13 PST
Ossy, this is landing material for Friday :)
Comment 4 WebKit Review Bot 2011-12-07 02:30:29 PST
Attachment 118193 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1

Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Hausmann 2011-12-07 02:33:59 PST
Created attachment 118194 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
Comment 6 Kenneth Rohde Christiansen 2011-12-07 04:09:44 PST
Comment on attachment 118194 [details]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module

This will land friday?
Comment 7 Csaba Osztrogon√°c 2011-12-09 01:12:38 PST
Fixed patch landed in http://trac.webkit.org/changeset/102445