Bug 73990

Summary: [Qt] Fix compilation with newly separated Qt 5 QtQuick module
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
none
[Qt] Fix compilation with newly separated Qt 5 QtQuick module none

Simon Hausmann
Reported 2011-12-07 01:50:52 PST
Latest qtdeclarative separates the QDeclarative* classes from the QQuick* classes by separating the latter out into a separate module. We need to adjust our sources to accommodate this.
Attachments
[Qt] Fix compilation with newly separated Qt 5 QtQuick module (12.88 KB, patch)
2011-12-07 02:27 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
[Qt] Fix compilation with newly separated Qt 5 QtQuick module (14.35 KB, patch)
2011-12-07 02:33 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-12-07 01:51:03 PST
(I'm working on this, in case it wasn't obvious :)
Simon Hausmann
Comment 2 2011-12-07 02:27:51 PST
Created attachment 118193 [details] [Qt] Fix compilation with newly separated Qt 5 QtQuick module
Simon Hausmann
Comment 3 2011-12-07 02:28:13 PST
Ossy, this is landing material for Friday :)
WebKit Review Bot
Comment 4 2011-12-07 02:30:29 PST
Attachment 118193 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1 Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:25: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Hausmann
Comment 5 2011-12-07 02:33:59 PST
Created attachment 118194 [details] [Qt] Fix compilation with newly separated Qt 5 QtQuick module
Kenneth Rohde Christiansen
Comment 6 2011-12-07 04:09:44 PST
Comment on attachment 118194 [details] [Qt] Fix compilation with newly separated Qt 5 QtQuick module This will land friday?
Csaba Osztrogonác
Comment 7 2011-12-09 01:12:38 PST
Fixed patch landed in http://trac.webkit.org/changeset/102445
Note You need to log in before you can comment on or make changes to this bug.