Bug 7399

Summary: Integrate CURL version of gettimeofday
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bugs-webkit, ian, jhaygood, webkit
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3356    
Attachments:
Description Flags
Quick fix to make StopWatch available on Windows none

Geoffrey Garen
Reported 2006-02-20 23:19:50 PST
CURL (http://curl.haxx.se/) has a platform-independent version of gettimeofday and related helpers. We should integrate it. It will make the StopWatch class in testkjs work on Windows. Long-term, it may also provide a simpler way to write platform independent date code.
Attachments
Quick fix to make StopWatch available on Windows (1.33 KB, patch)
2006-03-31 16:13 PST, Björn Graf (boki) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Björn Graf (boki)
Comment 1 2006-03-31 16:13:12 PST
Created attachment 7427 [details] Quick fix to make StopWatch available on Windows
Geoffrey Garen
Comment 2 2006-03-31 16:19:17 PST
Comment on attachment 7427 [details] Quick fix to make StopWatch available on Windows OK, but let's keep this bug open, because we still would like to integrate the CURL code.
Björn Graf (boki)
Comment 3 2006-03-31 16:24:47 PST
Maybe the CURL code will fix the issue on Windows where localtime returns 0 for invalid dates which causes lots of crashes with the unchecked dereferencing used all over the place.
Eric Seidel (no email)
Comment 4 2006-04-04 05:06:16 PDT
This patch is missing a ChangeLog as well as copyright. Please include those in future patches. I'll add the missing information as I land this time.
Geoffrey Garen
Comment 5 2006-04-04 09:26:25 PDT
Reopening. See my comment above.
Eric Seidel (no email)
Comment 6 2007-09-30 11:02:07 PDT
This bug has been stale for over a year. The windows port works. :) I think this can be closed.
Note You need to log in before you can comment on or make changes to this bug.