Summary: | [CSSRegion]Expose DOM interface for WebKitCSSRegionRule | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, japhet, macpherson, ojan, rakuco, simon.fraser, tony, vestbo, webkit-bug-importer, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 57312 | ||||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2011-12-06 23:53:16 PST
Created attachment 118191 [details]
Patch
Comment on attachment 118191 [details] Patch Attachment 118191 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10754086 Turns out this is due to bug 74027. In the mean time, you can implement the missing function. See Source/WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp for an example of this. Link to the reported bug in W3C bugzilla: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15116 Created attachment 123270 [details]
Patch 2
Comment on attachment 123270 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=123270&action=review r=me > Source/WebCore/css/WebKitCSSRegionRule.h:60 > + unsigned length() const { return m_ruleList->length(); } > + CSSRule* item(unsigned index) { return m_ruleList->item(index); } > + const CSSRule* item(unsigned index) const { return m_ruleList->item(index); } These are not used and so should not be in this patch. Created attachment 123307 [details]
Patch for landing
Comment on attachment 123307 [details] Patch for landing Clearing flags on attachment: 123307 Committed r105514: <http://trac.webkit.org/changeset/105514> All reviewed patches have been landed. Closing bug. |