Bug 73985

Summary: [CSSRegion]Expose DOM interface for WebKitCSSRegionRule
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, macpherson, ojan, rakuco, simon.fraser, tony, vestbo, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch 2
none
Patch for landing none

Mihnea Ovidenie
Reported 2011-12-06 23:53:16 PST
Add the DOM interface and expose cssRules attribute for start.
Attachments
Patch (53.52 KB, patch)
2011-12-07 02:18 PST, Mihnea Ovidenie 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch 2 (46.00 KB, patch)
2012-01-20 01:32 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.83 KB, patch)
2012-01-20 06:51 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2011-12-07 02:18:42 PST
Created attachment 118191 [details] Patch
WebKit Review Bot
Comment 2 2011-12-07 02:33:04 PST
Comment on attachment 118191 [details] Patch Attachment 118191 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10754086
Tony Chang
Comment 3 2011-12-07 14:29:26 PST
Turns out this is due to bug 74027. In the mean time, you can implement the missing function. See Source/WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp for an example of this.
Radar WebKit Bug Importer
Comment 4 2011-12-08 15:39:33 PST
<rdar://problem/10552260>
Mihnea Ovidenie
Comment 5 2011-12-09 01:03:34 PST
Link to the reported bug in W3C bugzilla: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15116
Mihnea Ovidenie
Comment 6 2012-01-20 01:32:33 PST
Created attachment 123270 [details] Patch 2
Antti Koivisto
Comment 7 2012-01-20 04:39:14 PST
Comment on attachment 123270 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=123270&action=review r=me > Source/WebCore/css/WebKitCSSRegionRule.h:60 > + unsigned length() const { return m_ruleList->length(); } > + CSSRule* item(unsigned index) { return m_ruleList->item(index); } > + const CSSRule* item(unsigned index) const { return m_ruleList->item(index); } These are not used and so should not be in this patch.
Mihnea Ovidenie
Comment 8 2012-01-20 06:51:14 PST
Created attachment 123307 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-01-20 07:33:38 PST
Comment on attachment 123307 [details] Patch for landing Clearing flags on attachment: 123307 Committed r105514: <http://trac.webkit.org/changeset/105514>
WebKit Review Bot
Comment 10 2012-01-20 07:33:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.