Bug 73985 – [CSSRegion]Expose DOM interface for WebKitCSSRegionRule

• Component: CSS
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Add the DOM interface and expose cssRules attribute for start.

[Mihnea Ovidenie]

Created attachment 118191 [details]
Patch

[WebKit Review Bot]

Comment on attachment 118191 [details]
Patch

Attachment 118191 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10754086

[Tony Chang]

Turns out this is due to bug 74027.  In the mean time, you can implement the missing function. See Source/WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp for an example of this.

[Radar WebKit Bug Importer]

<rdar://problem/10552260>

[Mihnea Ovidenie]

Link to the reported bug in W3C bugzilla: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15116

[Mihnea Ovidenie]

Created attachment 123270 [details]
Patch 2

[Antti Koivisto]

Comment on attachment 123270 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=123270&action=review

r=me

> Source/WebCore/css/WebKitCSSRegionRule.h:60
> +    unsigned length() const { return m_ruleList->length(); }
> +    CSSRule* item(unsigned index) { return m_ruleList->item(index); }
> +    const CSSRule* item(unsigned index) const { return m_ruleList->item(index); }

These are not used and so should not be in this patch.

[Mihnea Ovidenie]

Created attachment 123307 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 123307 [details]
Patch for landing

Clearing flags on attachment: 123307

Committed r105514: <http://trac.webkit.org/changeset/105514>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.