Bug 73984

Summary: TypingCommand duplicates code to obtain the last typing command
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, justin.garcia, leviw, morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64414    
Attachments:
Description Flags
cleanup tkent: review+

Description Ryosuke Niwa 2011-12-06 23:48:22 PST
Lots of code like:

    ASSERT(document);

    Frame* frame = document->frame();
    ASSERT(frame);

    EditCommand* lastEditCommand = frame->editor()->lastEditCommand();
    if (isOpenForMoreTypingCommand(lastEditCommand)) {

is duplicated throughout TypingCommand.
Comment 1 Ryosuke Niwa 2011-12-07 00:18:36 PST
Created attachment 118179 [details]
cleanup
Comment 2 Kent Tamura 2011-12-07 00:29:03 PST
Comment on attachment 118179 [details]
cleanup

Looks good.
Comment 3 Ryosuke Niwa 2011-12-07 00:55:40 PST
Thanks for the review!
Comment 4 Ryosuke Niwa 2011-12-07 01:03:58 PST
Committed r102225: <http://trac.webkit.org/changeset/102225>