Bug 73947

Summary:

GC zapping logic could benefit from some more assertions

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Filip Pizlo 2011-12-06 13:34:52 PST

Patch forthcoming

Comment 1 Filip Pizlo 2011-12-06 13:37:01 PST

Created attachment 118103 [details]
the patch

Comment 2 Gavin Barraclough 2011-12-06 13:45:36 PST

Comment on attachment 118103 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118103&action=review

> Source/JavaScriptCore/heap/MarkedBlock.h:293
> +            }

This could be:
    ASSERT(!isZapped(cell) || !m_marks.get(atomNumber(cell)));
    return !isZapped(cell);

Comment 3 WebKit Review Bot 2011-12-06 13:51:39 PST

Attachment 118103 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/heap/MarkedBlock.h:285:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Filip Pizlo 2011-12-06 14:13:11 PST

Landed in http://trac.webkit.org/changeset/102179

Comment 5 Filip Pizlo 2011-12-06 14:13:23 PST

Comment on attachment 118103 [details]
the patch

Clearing flags.