Summary: | [EFL] Do not lose message flags when soup resources are converted. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
Component: | WebKit EFL | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, leandro, lucas.de.marchi, mrobinson, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Raphael Kubo da Costa (:rakuco)
2011-12-06 08:15:49 PST
Attachment 118053 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 118055 [details]
Add bug number to ChangeLog
Comment on attachment 118055 [details] Add bug number to ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=118055&action=review > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:239 > +void FrameLoaderClientEfl::dispatchDidReceiveResponse(DocumentLoader* loader, unsigned long, const ResourceResponse& response) > { > +#if USE(SOUP) > + // Update our knowledge of request soup flags - some are only set > + // after the request is done. > + loader->request().setSoupMessageFlags(response.soupMessageFlags()); > +#endif If you want your build to be really tidy in the non-soup case you should probably have UNUSED_PARAM(loader); in an #else block here, looks good otherwise. Created attachment 118077 [details]
Patch for landing
Committed r102159: <http://trac.webkit.org/changeset/102159> |