Bug 73921 – [Qt] Rendering issues with sliders and QStyle

• Component: New Bugs
• Status: RESOLVED FIXED

[Pierre Rossi]

[Qt] Rendering issues with sliders and QStyle

[Pierre Rossi]

Created attachment 118045 [details]
Patch

[Simon Hausmann]

Comment on attachment 118045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118045&action=review

> Source/WebCore/platform/qt/RenderThemeQStyle.cpp:806
> +#ifndef QT_NO_STYLE_MOTIF
> +        // Motif style sliders have a border on each side that needs to be accounted for
> +        if (qobject_cast<QMotifStyle*>(qstyle))
> +            length += 2 * qstyle->pixelMetric(QStyle::PM_DefaultFrameWidth);
> +#endif

Hmm, can we leave out this part of the patch? :)

An #ifdef, a qobject_cast and an #include for a configuration that is beyond being just obsolete? :)

[Pierre Rossi]

Created attachment 118206 [details]
Patch

[Simon Hausmann]

Comment on attachment 118206 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 118206 [details]
Patch

Rejecting attachment 118206 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 118206 [details]
Patch

Clearing flags on attachment: 118206

Committed r102589: <http://trac.webkit.org/changeset/102589>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.