Bug 73916 – Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.

• Component: New Bugs
• Status: RESOLVED FIXED

[Pierre Rossi]

Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.

[Pierre Rossi]

Created attachment 118040 [details]
Patch

[Kent Tamura]

Comment on attachment 118040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118040&action=review

Thank you for working on this!

> Source/WebCore/html/HTMLSelectElement.cpp:187
> +    Page* page = 0;
> +    if (Frame* frame = document()->frame())
> +        page = frame->page();

We have Document::page().

> Source/WebCore/html/HTMLSelectElement.cpp:188
> +    RenderTheme* renderTheme = page ? page->theme() : RenderTheme::defaultTheme().leakRef();

Do not leak.
This should be RefPtr<RenterTheme> renderTheme = ...

> Source/WebCore/rendering/RenderTheme.h:210
> +    virtual bool usesMenuList() const { return false; }

The function name should be more descriptive.  selectElementAlwaysUsesMenuList() or something?

[Pierre Rossi]

Created attachment 118203 [details]
Patch

@Kent: thanks for taking a look at this. Any idea what render themes in chromium would need to switch to this ? I failed to track the define all the way.

[Kent Tamura]

(In reply to comment #3)
> @Kent: thanks for taking a look at this. Any idea what render themes in chromium would need to switch to this ? I failed to track the define all the way.

I think Android port is using ENABLE_NO_LISTBOX_RENDERING, but RenderTheme for Android is not upstreamed yet.  So you don't need to care about it.

[Kent Tamura]

Comment on attachment 118203 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 118203 [details]
Patch

Rejecting attachment 118203 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 118203 [details]
Patch

Clearing flags on attachment: 118203

Committed r102419: <http://trac.webkit.org/changeset/102419>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.