Bug 73913 – [WK2] New tests introduced in r100895 fail

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

Same fails on SL-WK2 and on Qt-WK2: FAIL: Timed out waiting for notifyDone to be called

http/tests/security/referrer-policy-https-always.html: 
http/tests/security/referrer-policy-https-origin.html
http/tests/security/referrer-policy-redirect.html
http/tests/security/referrer-policy-https-never.html
http/tests/security/referrer-policy-https-default.html

When did those tests start to fail?

[Csaba Osztrogonác]

(In reply to comment #1)
> When did those tests start to fail?

Since they are introduced: r100895.

[Csaba Osztrogonác]

I skipped them to make buildbots a little bit happier: http://trac.webkit.org/changeset/102127

ok, I will look into why this fails

The tests work locally, although they're all pretty slow on WK2. The difference between these and the remaining tests in that CL is that they redirect through https

Could this cause the slowness?

Actually, it's not slowness, but WebKitTestRunner doesn't load resources over https for whatever reason.

Other tests requiring ssl (like all in http/tests/ssl/) are disabled as well

[Alexey Proskuryakov]

In Mac case at least, that could be because of a self signed certificate. DRT has code to silence those, while WTR does not.

[NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
[NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];

(In reply to comment #7)
> In Mac case at least, that could be because of a self signed certificate. DRT has code to silence those, while WTR does not.
> 
> [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
> [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];


that might be very well true (I've tried to get the tests work on a Mac).

I guess that code needs to be run in the same process that does the actual loading. I've put these lines in InjectedBundle/mac/LayoutTestControllerMac::platformInitialize, but the tests still don't work 

Given that I don't know much about the WebKitTestRunner, this might be the wrong place... I'll continue to look into this

[Roger Fong]

DRT has similar issues. 
I''m testing on Windows.
Adding to skip list as well.

[Alexey Proskuryakov]

> [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
> [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];

WebKitTestRunner now does this in InjectedBundleMac.mm. Are the tests still failing?

[Marja Hölttä]

These seem to be passing now afaics. I'll attach a patch to unskip them.

[Marja Hölttä]

Created attachment 186826 [details]
Patch

Comment on attachment 186826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186826&action=review

r=me

> LayoutTests/ChangeLog:3
> +        Unskipping tests which no longer fail.

could you add some more details: something like unskipping referrer policy tests now that WTR supports https tests

[Marja Hölttä]

Created attachment 186828 [details]
Patch

[Marja Hölttä]

Comment on attachment 186828 [details]
Patch

(Added more information in the ChangeLog.)

[WebKit Review Bot]

Comment on attachment 186828 [details]
Patch

Clearing flags on attachment: 186828

Committed r141994: <http://trac.webkit.org/changeset/141994>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.