Bug 73899

Summary:

[V8] Multiple VMs: refactor SerializedScriptValue.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

donggwan.kim

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[DRAFT]	none

Pavel Podivilov

Reported 2011-12-06 02:56:56 PST

Extract v8 specific object traverse/construct to dedicated classes.

Attachments
[DRAFT] (50.42 KB, patch) 2011-12-06 02:59 PST, Pavel Podivilov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-12-06 02:59:09 PST

Created attachment 118014 [details] [DRAFT]

Eric Seidel (no email)

Comment 2 2011-12-06 12:20:00 PST

Comment on attachment 118014 [details] [DRAFT] View in context: https://bugs.webkit.org/attachment.cgi?id=118014&action=review > Source/WebCore/bindings/v8/SerializedScriptValue.cpp:1437 > + bool readImageData(ScriptValueDeserializer& deserializer) I cant think of any time in WebKit that we pass around a non-pod object by reference. I guess RefPtr<>, but that's a template. Although I suspect the compiler might do the right thing with virtual disapatch, since & isn't that different from *, I doubt this is kosher.

Brian Burg

Comment 3 2014-12-16 00:48:13 PST

Closing some V8-related work items.

Note You need to log in before you can comment on or make changes to this bug.