Bug 73859

Summary:

REGRESSION(r101949): css3/bdi-element.html fails on Lion

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Text

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
fixes the expected result	mitz: review+

Description Ryosuke Niwa 2011-12-05 13:21:02 PST

css3/bdi-element.html fails because:

https://bugs.webkit.org/show_bug.cgi?id=73680
 Comment #9 From mitz@webkit.org 2011-12-04 15:00:59 PST (-) [reply] 
(In reply to comment #8)
> On Mac Lion, css3/bdi-element.html is now failing.
> 
> The text ": 3 posts" is 1 pixel further to the left in the reference rendering compared to the test result.
> 
> The technique we are using here may be incorrect.

Right, an inline can have a non-integral width, but the reference rendering uses an inline block, whose width is always rounded up.

Comment 1 Ryosuke Niwa 2011-12-05 13:28:02 PST

Created attachment 117931 [details]
fixes the expected result

Comment 2 Ryosuke Niwa 2011-12-05 15:57:32 PST

Committed r102060: <http://trac.webkit.org/changeset/102060>

Comment 3 Ryosuke Niwa 2011-12-05 15:59:18 PST

Thanks for the review! Sorry it took so long. Had an issue on laptop's svn checkout so had to wait 'til this morning to create the patch :(