Bug 73797

Summary: Update String::containsOnlyLatin1() to avoid converting to 16 bits
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-12-04 21:29:35 PST
Update String::containsOnlyLatin1() to avoid converting to 16 bits
Attachments
Patch (3.37 KB, patch)
2011-12-04 21:44 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-12-04 21:44:59 PST
Created attachment 117839 [details] Patch
Andreas Kling
Comment 2 2011-12-05 09:58:31 PST
Comment on attachment 117839 [details] Patch Delightful!
Darin Adler
Comment 3 2011-12-05 10:44:05 PST
Comment on attachment 117839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117839&action=review > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) Why remove this? Why not just call it?
Benjamin Poulain
Comment 4 2011-12-05 10:48:17 PST
> > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) > > Why remove this? Why not just call it? I thought removing it would reduce the complexity here since it is never used.
Benjamin Poulain
Comment 5 2011-12-05 10:52:26 PST
(In reply to comment #4) > > > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > > > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) > > > > Why remove this? Why not just call it? > > I thought removing it would reduce the complexity here since it is never used. Do you want me to add it back? I don't mind.
WebKit Review Bot
Comment 6 2011-12-05 12:28:03 PST
Comment on attachment 117839 [details] Patch Clearing flags on attachment: 117839 Committed r102028: <http://trac.webkit.org/changeset/102028>
WebKit Review Bot
Comment 7 2011-12-05 12:28:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.