Bug 73793

Summary:

CSSStyleSheet can't be reparented, enforce this at compile time.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2011-12-04 19:17:16 PST

We should replace CSSStyleSheet's setParentRule() by clearParentRule() to enforce the fact that CSSStyleSheet can't be moved to another parent rule after creation.

Comment 1 Andreas Kling 2011-12-04 20:52:11 PST

Created attachment 117835 [details]
Patch

Comment 2 Benjamin Poulain 2011-12-04 21:26:01 PST

Comment on attachment 117835 [details]
Patch

The pach looks good. I am unfamiliar with the naming preference owner/parentRule but that seem consistent with CSSOM.

Comment 3 Andreas Kling 2011-12-04 21:44:08 PST

Comment on attachment 117835 [details]
Patch

Clearing flags on attachment: 117835

Committed r101972: <http://trac.webkit.org/changeset/101972>

Comment 4 Andreas Kling 2011-12-04 21:44:16 PST

All reviewed patches have been landed.  Closing bug.