Bug 73790 – [EFL] Add RefPtrEfl specialization for evas_object.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[KwangHyuk]

As evas_object is also based on reference count, RefPtr is applied for evas_object.

[KwangHyuk]

Created attachment 118316 [details]
[EFL] Add RefPtrEfl specialization for evas_object.

As evas_object is also based on reference count, RefPtr is applied for evas_object.

[KwangHyuk]

FYI, as evas_object_del doesn't unref object by itself, both evas_object_unref and evas_object_del are required for derefIfNotNull.

EAPI void
evas_object_del(Evas_Object *obj)
{
   MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ);
   return;
   MAGIC_CHECK_END();

   if (obj->delete_me) return;

   if (obj->ref > 0)
     {
        obj->del_ref = 1;
        return;
     }

[Ryosuke Niwa]

Comment on attachment 118316 [details]
[EFL] Add RefPtrEfl specialization for evas_object.

View in context: https://bugs.webkit.org/attachment.cgi?id=118316&action=review

> Source/WebCore/platform/efl/RefPtrEfl.cpp:28
> +    if (LIKELY(ptr != 0))

WebKit style is not to compare with 0. So you should do LIKELY(ptr) or LIKELY(!!ptr)

[KwangHyuk]

Created attachment 118538 [details]
Patch updated.

[Gyuyoung Kim]

Comment on attachment 118538 [details]
Patch updated.

Attachment 118538 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10790616

[KwangHyuk]

Created attachment 118542 [details]
Patch.

[WebKit Review Bot]

Comment on attachment 118542 [details]
Patch.

Clearing flags on attachment: 118542

Committed r102480: <http://trac.webkit.org/changeset/102480>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.