Bug 73778

Summary: Change YARR code to use Vector<OwnPtr>
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 73757    
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2011-12-04 13:11:51 PST
Change YARR code to use HashMap<OwnPtr>
Attachments
Patch (26.83 KB, patch)
2011-12-04 13:26 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (27.65 KB, patch)
2012-06-07 10:59 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-12-04 13:26:57 PST
Created attachment 117805 [details] Patch
Darin Adler
Comment 2 2011-12-04 13:27:19 PST
The attached patch must be almost right, but not quite, because with the patch applied there are test failures.
Darin Adler
Comment 3 2011-12-04 13:28:23 PST
Maybe Vector<OwnPtr> doesn’t work right yet when resizing?
WebKit Review Bot
Comment 4 2011-12-26 07:10:54 PST
Comment on attachment 117805 [details] Patch Attachment 117805 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11038100 New failing tests: http/tests/inspector-enabled/dedicated-workers-list.html fast/files/read-file-async.html http/tests/inspector/resource-tree/resource-tree-document-url.html fast/files/file-reader-fffd.html http/tests/inspector/search/search-in-script.html fast/files/workers/worker-read-file-async.html fast/encoding/preload-encoding.html fast/encoding/char-decoding.html http/tests/workers/text-encoding.html http/tests/xmlhttprequest/binary-x-user-defined.html fast/forms/ValidityState-typeMismatch-email.html fast/forms/ValidityState-patternMismatch-unsupported.html fast/forms/validationMessage.html fast/forms/ValidityState-patternMismatch.html fast/files/workers/worker-read-file-sync.html fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src.html fast/encoding/external-script-charset.xhtml http/tests/inspector/search/search-in-resource.html
Darin Adler
Comment 5 2012-06-07 10:59:00 PDT
Created attachment 146327 [details] Patch
Darin Adler
Comment 6 2012-06-07 11:21:23 PDT
Patch is not good. Causes failures and crashes.
Darin Adler
Comment 7 2013-05-26 18:13:50 PDT
*** This bug has been marked as a duplicate of bug 109218 ***
Note You need to log in before you can comment on or make changes to this bug.