Summary: | Use HashMap<OwnPtr> for EventListenerMap's internal map. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | UI Events | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2011-12-03 21:28:33 PST
Created attachment 117781 [details]
Patch
Comment on attachment 117781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117781&action=review Nice > Source/WebCore/dom/EventListenerMap.cpp:-79 > - if (m_hashMap) { > - deleteAllValues(*m_hashMap); > + if (m_hashMap) > m_hashMap.clear(); > - } else { Here your patch does two things: fix the style && change the code. You should make a separate patch for the style fix, then apply your hash map fix... :-D (In reply to comment #2) > (From update of attachment 117781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117781&action=review > > Nice > > > Source/WebCore/dom/EventListenerMap.cpp:-79 > > - if (m_hashMap) { > > - deleteAllValues(*m_hashMap); > > + if (m_hashMap) > > m_hashMap.clear(); > > - } else { > > Here your patch does two things: fix the style && change the code. > You should make a separate patch for the style fix, then apply your hash map fix... :-D ... Sorry, brah. It won't happen again :) Comment on attachment 117781 [details] Patch Clearing flags on attachment: 117781 Committed r102106: <http://trac.webkit.org/changeset/102106> All reviewed patches have been landed. Closing bug. |