Summary: | [GTK] Bad text rendering since r101343 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, dglazkov, gyuyoung.kim, mcatanzaro, mrobinson, rakuco, webkit.review.bot, webkit, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 76520 | ||||||||
Attachments: |
|
Description
Philippe Normand
2011-12-03 08:57:18 PST
Can the EFL folks please have a look at this issue as well? I'm about to upload a patch for GTK. Created attachment 117760 [details]
proposed patch
Comment on attachment 117760 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=117760&action=review Looks good to me, but you'll also need to make this change in WebKit2. > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:159 > + if (GdkScreen* screen = gdk_screen_get_default()) { You should probably ASSERT screen and screenOptions here instead of using an if. Created attachment 117762 [details]
proposed patch
Comment on attachment 117762 [details] proposed patch Attachment 117762 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10727476 New failing tests: svg/custom/linking-uri-01-b.svg (In reply to comment #1) > Can the EFL folks please have a look at this issue as well? I'm about to upload a patch for GTK. CC'ing kubo, Hello kubo, it looks we may have similar problem. Does EFL DRT also need to adjust similar patch? Comment on attachment 117762 [details] proposed patch Landed http://trac.webkit.org/changeset/102748 Patch landed, this can be closed? Yes. |