Bug 73744 – [GTK] Bad text rendering since r101343

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Philippe Normand]

Disabling CAIRO_HINT_METRICS is good for the tests only it seems. Cairo-based ports should do this in their DRT only.

[Philippe Normand]

Can the EFL folks please have a look at this issue as well? I'm about to upload a patch for GTK.

[Philippe Normand]

Created attachment 117760 [details]
proposed patch

[Martin Robinson]

Comment on attachment 117760 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117760&action=review

Looks good to me, but you'll also need to make this change in WebKit2.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:159
> +    if (GdkScreen* screen = gdk_screen_get_default()) {

You should probably ASSERT screen and screenOptions here instead of using an if.

[Philippe Normand]

Created attachment 117762 [details]
proposed patch

[WebKit Review Bot]

Comment on attachment 117762 [details]
proposed patch

Attachment 117762 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10727476

New failing tests:
svg/custom/linking-uri-01-b.svg

[Gyuyoung Kim]

(In reply to comment #1)
> Can the EFL folks please have a look at this issue as well? I'm about to upload a patch for GTK.

CC'ing kubo, 

Hello kubo, it looks we may have similar problem. Does EFL DRT also need to adjust similar patch?

[Philippe Normand]

Comment on attachment 117762 [details]
proposed patch

Landed http://trac.webkit.org/changeset/102748

[Lionir]

Patch landed, this can be closed?

[Michael Catanzaro]

Yes.