Bug 73725

Summary:

CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, japhet, koivisto, macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, webkit.review.bot: commit-queue-
Patch for landing	none

Description Andreas Kling 2011-12-02 17:47:56 PST

Per CSSOM (and our implementation), a CSSStyleSheet's parent rule can only ever be a CSSImportRule. We should enforce this at compile time instead of allowing any CSSRule as parent.

Comment 1 Andreas Kling 2011-12-02 18:01:00 PST

Created attachment 117722 [details]
Patch

Comment 2 WebKit Review Bot 2011-12-02 18:42:52 PST

Comment on attachment 117722 [details]
Patch

Attachment 117722 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10725619

Comment 3 Andreas Kling 2011-12-03 17:32:43 PST

Created attachment 117778 [details]
Patch for landing

Same patch with CodeGeneratorV8.pm tweaked to include CSSImportRule.h for CSSStyleSheet and StyleSheet bindings.

Comment 4 Andreas Kling 2011-12-03 19:51:38 PST

Committed r101943: <http://trac.webkit.org/changeset/101943>