| Summary: | [JSC] Implement correct order of window.postMessage arguments | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Lomov <dslomov> | ||||||||
| Component: | WebCore JavaScript | Assignee: | Dmitry Lomov <dslomov> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dslomov, levin, ojan, oliver, ossy, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 73739 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dmitry Lomov
2011-12-02 13:45:55 PST
Created attachment 117691 [details]
Fix
Comment on attachment 117691 [details]
Fix
Would be nice to add a reference to the specification change that motivated this in your ChangeLog. Or were the JSC bindings for postMessage always wrong?
(In reply to comment #2) > (From update of attachment 117691 [details]) > Would be nice to add a reference to the specification change that motivated this in your ChangeLog. Or were the JSC bindings for postMessage always wrong? Yes they were always wrong (the addition of transfer list is very recent change). Comment on attachment 117691 [details] Fix Clearing flags on attachment: 117691 Committed r101904: <http://trac.webkit.org/changeset/101904> All reviewed patches have been landed. Closing bug. Reopen, because it was rolled out. (I don't have time to debug other's patch at my weekend, and we shouldn't leave all bots broken for two days.) It broke many inspector tests on SL, GTK and Qt bots: http://build.webkit.org/results/Qt%20Linux%20Release/r101904%20%2840534%29/results.html http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r101909%20%2819682%29/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r101907%20%2835149%29/results.html (In reply to comment #6) > Reopen, because it was rolled out. (I don't have time to debug other's patch at my weekend, and we shouldn't leave all bots broken for two days.) > > It broke many inspector tests on SL, GTK and Qt bots: > http://build.webkit.org/results/Qt%20Linux%20Release/r101904%20%2840534%29/results.html > http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r101909%20%2819682%29/results.html > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r101907%20%2835149%29/results.html Yikes, thanks so much for taking care of this!!! Created attachment 118603 [details]
Updated fix.
Implements the new spec for window.postMessage, while keeping backwards-compatibility with webkit proprietary legacy behavior
Comment on attachment 118603 [details] Updated fix. View in context: https://bugs.webkit.org/attachment.cgi?id=118603&action=review > LayoutTests/ChangeLog:15 > +2011-12-08 Dmitry Lomov <dslomov@google.com> dup change log that needs removal. Created attachment 119102 [details]
Fixed changelog
Comment on attachment 119102 [details] Fixed changelog Clearing flags on attachment: 119102 Committed r102722: <http://trac.webkit.org/changeset/102722> All reviewed patches have been landed. Closing bug. |