Bug 73691

Summary: [JSC] Implement correct order of window.postMessage arguments
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: WebCore JavaScriptAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dslomov, levin, ojan, oliver, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73739    
Bug Blocks:    
Attachments:
Description Flags
Fix
none
Updated fix.
levin: review+
Fixed changelog none

Dmitry Lomov
Reported 2011-12-02 13:45:55 PST
Amd fix fast/dom/Window/window-postmessage-args-expected.txt
Attachments
Fix (5.55 KB, patch)
2011-12-02 14:22 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Updated fix. (8.78 KB, patch)
2011-12-09 12:00 PST, Dmitry Lomov 		levin: review+
DetailsFormatted DiffDiff
Fixed changelog (8.57 KB, patch)
2011-12-13 16:15 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-12-02 14:22:19 PST
Created attachment 117691 [details] Fix
Geoffrey Garen
Comment 2 2011-12-02 14:29:09 PST
Comment on attachment 117691 [details] Fix Would be nice to add a reference to the specification change that motivated this in your ChangeLog. Or were the JSC bindings for postMessage always wrong?
Dmitry Lomov
Comment 3 2011-12-02 14:32:19 PST
(In reply to comment #2) > (From update of attachment 117691 [details]) > Would be nice to add a reference to the specification change that motivated this in your ChangeLog. Or were the JSC bindings for postMessage always wrong? Yes they were always wrong (the addition of transfer list is very recent change).
WebKit Review Bot
Comment 4 2011-12-02 21:41:03 PST
Comment on attachment 117691 [details] Fix Clearing flags on attachment: 117691 Committed r101904: <http://trac.webkit.org/changeset/101904>
WebKit Review Bot
Comment 5 2011-12-02 21:41:07 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-12-03 01:09:48 PST
Reopen, because it was rolled out. (I don't have time to debug other's patch at my weekend, and we shouldn't leave all bots broken for two days.) It broke many inspector tests on SL, GTK and Qt bots: http://build.webkit.org/results/Qt%20Linux%20Release/r101904%20%2840534%29/results.html http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r101909%20%2819682%29/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r101907%20%2835149%29/results.html
Dmitry Lomov
Comment 7 2011-12-05 10:40:51 PST
(In reply to comment #6) > Reopen, because it was rolled out. (I don't have time to debug other's patch at my weekend, and we shouldn't leave all bots broken for two days.) > > It broke many inspector tests on SL, GTK and Qt bots: > http://build.webkit.org/results/Qt%20Linux%20Release/r101904%20%2840534%29/results.html > http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r101909%20%2819682%29/results.html > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r101907%20%2835149%29/results.html Yikes, thanks so much for taking care of this!!!
Dmitry Lomov
Comment 8 2011-12-09 12:00:58 PST
Created attachment 118603 [details] Updated fix. Implements the new spec for window.postMessage, while keeping backwards-compatibility with webkit proprietary legacy behavior
David Levin
Comment 9 2011-12-13 15:51:07 PST
Comment on attachment 118603 [details] Updated fix. View in context: https://bugs.webkit.org/attachment.cgi?id=118603&action=review > LayoutTests/ChangeLog:15 > +2011-12-08 Dmitry Lomov <dslomov@google.com> dup change log that needs removal.
Dmitry Lomov
Comment 10 2011-12-13 16:15:04 PST
Created attachment 119102 [details] Fixed changelog
WebKit Review Bot
Comment 11 2011-12-13 17:17:58 PST
Comment on attachment 119102 [details] Fixed changelog Clearing flags on attachment: 119102 Committed r102722: <http://trac.webkit.org/changeset/102722>
WebKit Review Bot
Comment 12 2011-12-13 17:18:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.