Bug 73687

Summary: [chromium] Separate setFocus() and setActive() in WebViewImpl
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebKit Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Nate Chapin
Reported 2011-12-02 13:31:37 PST
See: http://code.google.com/p/chromium/issues/detail?id=101455 http://trac.webkit.org/changeset/96912 Historically, chromium has only explicitly sent IPCs for setting a WebView as active on mac. http://src.chromium.org/viewvc/chrome?view=rev&revision=108392 changed this. Now, WebViewImpl::setFocus() shouldn't need to call FocusController::setActive() to get proper behavior.
Attachments
patch (2.62 KB, patch)
2011-12-02 14:32 PST, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2011-12-02 14:32:31 PST
Created attachment 117692 [details] patch
Eric Seidel (no email)
Comment 2 2011-12-02 14:48:52 PST
Comment on attachment 117692 [details] patch seems reasonable.
Eric Seidel (no email)
Comment 3 2011-12-02 14:49:09 PST
CCing fishd as it's API related.
Darin Fisher (:fishd, Google)
Comment 4 2011-12-02 15:19:47 PST
Comment on attachment 117692 [details] patch OK
WebKit Review Bot
Comment 5 2011-12-02 21:51:18 PST
Comment on attachment 117692 [details] patch Clearing flags on attachment: 117692 Committed r101905: <http://trac.webkit.org/changeset/101905>
WebKit Review Bot
Comment 6 2011-12-02 21:51:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.