Bug 73666

Summary: [GTK] http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Takashi Toyoshima <toyoshim>
Status: RESOLVED FIXED    
Severity: Normal CC: svillar, tkent, toyoshim, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2011-12-02 08:57:41 PST
--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 0: WebSocket network error: error code 0 Web Socket bufferedAmount after closed in busy On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Not sure what to do here. Any hint? Takashi?
Attachments
Patch (2.36 KB, patch)
2011-12-08 01:10 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-12-06 11:37:24 PST
Thank you for letting me know. This new test closes WebSocket connection when sending buffer is not empty. In this situation, platformSend will be called after connection start to close, or is in CLOSING state. I think this console message is related to the case. I'll investigate it.
Takashi Toyoshima
Comment 2 2011-12-08 01:10:56 PST
Created attachment 118345 [details] Patch
Takashi Toyoshima
Comment 3 2011-12-08 01:14:53 PST
Sorry, the reason was in my test. Server side handler began server initiated closing handshake unexpectedly. Anyway, current SocketStreamHandlerError doesn't contain message to show in log. I'll also post a patch to improve it soon. Thanks
Kent Tamura
Comment 4 2011-12-08 02:06:07 PST
Comment on attachment 118345 [details] Patch ok
WebKit Review Bot
Comment 5 2011-12-08 02:45:06 PST
Comment on attachment 118345 [details] Patch Clearing flags on attachment: 118345 Committed r102327: <http://trac.webkit.org/changeset/102327>
WebKit Review Bot
Comment 6 2011-12-08 02:45:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.