| Summary: | [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
| Component: | Tools / Tests | Assignee: | Kentaro Hara <haraken> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 117616 [details]
check if all builds succeed
Created attachment 117719 [details]
Patch
Comment on attachment 117719 [details] Patch Clearing flags on attachment: 117719 Committed r101914: <http://trac.webkit.org/changeset/101914> All reviewed patches have been landed. Closing bug. |
The code in CodeGenerator*.pm to build a method argument string is really dirty and error-prone. It is building an argument string incrementally judging whether ", " is necessary or not, like this: my $method = ... ? "func(" : "func(a"; if (...) { $method .= $method =~ /\($/ ? "b" : ", b"; } $method .= ")"; Alternatively, we can refactor the code as follows: my $funcName = "func"; my @arguments; push(@arguments, "a") if (...); push(@arguments, "b") if (...); my $method = $funcName . "(" . join(", ", @arguments) . ")";