Summary: | [Chromium] [WebSocket] Add binary support in echo test server | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takashi Toyoshima <toyoshim> | ||||
Component: | WebCore Misc. | Assignee: | Takashi Toyoshima <toyoshim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, tkent, webkit.review.bot, yutak | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Takashi Toyoshima
2011-12-02 05:38:34 PST
Created attachment 117612 [details]
Patch
Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Looks fine. (Note: I'm not a WebKit reviewer yet) > LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 > +# Copyright 2009, 2011, Google Inc. Just replace the old year to the new one instead of appending. (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review >> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >> +# Copyright 2009, 2011, Google Inc. > > Just replace the old year to the new one instead of appending. > > (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) Another reviewer suggest me adding new year instead of replacing one as a WebKit style. Any guideline to know which file follows which rule? FYI; this echo_wsh.py is totally based on pywebsocket example. Old echo_wsh.py come from old pywebsocket, and new echo_wsh.py after this change com from the latest pywebsocket. Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Seems reasonable. >>> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >>> +# Copyright 2009, 2011, Google Inc. >> >> Just replace the old year to the new one instead of appending. >> >> (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) > > Another reviewer suggest me adding new year instead of replacing one as a WebKit style. > Any guideline to know which file follows which rule? It doesn't matter. :) Anyone who feels it matters should fix check-webkit-style to enforce one or the other. :) Until then, I would tell you not to worry about it. Eric, Thank you for an advice on copyright, and r+. Comment on attachment 117612 [details] Patch Clearing flags on attachment: 117612 Committed r101974: <http://trac.webkit.org/changeset/101974> All reviewed patches have been landed. Closing bug. |