Bug 73649

Summary: [Chromium] [WebSocket] Add binary support in echo test server
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: WebCore Misc.Assignee: Takashi Toyoshima <toyoshim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Takashi Toyoshima
Reported 2011-12-02 05:38:34 PST
For now, LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py supports only text frames. This must support binary frames for chromium side tests.
Attachments
Patch (1.98 KB, patch)
2011-12-02 05:44 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-12-02 05:44:22 PST
Created attachment 117612 [details] Patch
Yuta Kitamura
Comment 2 2011-12-02 06:16:15 PST
Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Looks fine. (Note: I'm not a WebKit reviewer yet) > LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 > +# Copyright 2009, 2011, Google Inc. Just replace the old year to the new one instead of appending. (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers)
Takashi Toyoshima
Comment 3 2011-12-02 09:02:51 PST
Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review >> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >> +# Copyright 2009, 2011, Google Inc. > > Just replace the old year to the new one instead of appending. > > (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) Another reviewer suggest me adding new year instead of replacing one as a WebKit style. Any guideline to know which file follows which rule?
Takashi Toyoshima
Comment 4 2011-12-02 16:41:43 PST
FYI; this echo_wsh.py is totally based on pywebsocket example. Old echo_wsh.py come from old pywebsocket, and new echo_wsh.py after this change com from the latest pywebsocket.
Eric Seidel (no email)
Comment 5 2011-12-03 13:29:54 PST
Comment on attachment 117612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Seems reasonable. >>> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >>> +# Copyright 2009, 2011, Google Inc. >> >> Just replace the old year to the new one instead of appending. >> >> (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) > > Another reviewer suggest me adding new year instead of replacing one as a WebKit style. > Any guideline to know which file follows which rule? It doesn't matter. :) Anyone who feels it matters should fix check-webkit-style to enforce one or the other. :) Until then, I would tell you not to worry about it.
Takashi Toyoshima
Comment 6 2011-12-04 21:59:02 PST
Eric, Thank you for an advice on copyright, and r+.
WebKit Review Bot
Comment 7 2011-12-04 23:42:35 PST
Comment on attachment 117612 [details] Patch Clearing flags on attachment: 117612 Committed r101974: <http://trac.webkit.org/changeset/101974>
WebKit Review Bot
Comment 8 2011-12-04 23:42:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.