Bug 73641 – WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed

[Andy Estes]

Created attachment 117598 [details]
Patch

[Darin Adler]

Comment on attachment 117598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117598&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:537
> -    if (m_frame == m_frame->page()->mainWebFrame())
> +    if (m_frame == m_frame->page()->mainWebFrame() && !webPage->corePage()->settings()->suppressIncrementalRendering())
>          webPage->drawingArea()->setLayerTreeStateIsFrozen(false);

Seems OK, but perhaps a bit of a layering problem that this code needs to check the setting.

Not sure why this code gets to the page as m_frame->page() in one half of the expression and as webPage->corePage() in the other. Aren’t those guaranteed to be the same page?

[Andy Estes]

(In reply to comment #2)
> (From update of attachment 117598 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117598&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:537
> > -    if (m_frame == m_frame->page()->mainWebFrame())
> > +    if (m_frame == m_frame->page()->mainWebFrame() && !webPage->corePage()->settings()->suppressIncrementalRendering())
> >          webPage->drawingArea()->setLayerTreeStateIsFrozen(false);
> 
> Seems OK, but perhaps a bit of a layering problem that this code needs to check the setting.
> 
> Not sure why this code gets to the page as m_frame->page() in one half of the expression and as webPage->corePage() in the other. Aren’t those guaranteed to be the same page?

One is a WebKit2 WebPage and the other is it's corresponding WebCore::Page. I need the WebCore::Page to get at the Settings object.

Thanks for the review!

[Andy Estes]

I swear I know the difference between it's and its :/

[Andy Estes]

Committed r101838: <http://trac.webkit.org/changeset/101838>