Summary: | [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | Tools / Tests | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kentaro Hara
2011-12-02 02:19:13 PST
Created attachment 117593 [details]
Patch
I forget whether run_command or run_and_throw_if_failed is preferred. @Eric? (In reply to comment #2) > I forget whether run_command or run_and_throw_if_failed is preferred. > > @Eric? run_command. Comment on attachment 117593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117593&action=review > Tools/Scripts/webkitpy/common/system/executive.py:403 > + return_exit_code_and_output=False, Why not just catch the exception? That's what we usually do in these cases. The ScriptError has all the data. Created attachment 117972 [details]
Patch
Comment on attachment 117972 [details]
Patch
Thanks.
Comment on attachment 117972 [details] Patch Clearing flags on attachment: 117972 Committed r102105: <http://trac.webkit.org/changeset/102105> All reviewed patches have been landed. Closing bug. |