Bug 73637

Summary: [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Tools / TestsAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2011-12-02 02:19:13 PST
We can replace subprocess.Popen() with Executive, similar to other Python scripts in webkitpy/.
Attachments
Patch (6.15 KB, patch)
2011-12-02 02:29 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (5.23 KB, patch)
2011-12-05 18:09 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-02 02:29:29 PST
Created attachment 117593 [details] Patch
Adam Barth
Comment 2 2011-12-02 10:36:59 PST
I forget whether run_command or run_and_throw_if_failed is preferred. @Eric?
Eric Seidel (no email)
Comment 3 2011-12-02 10:42:49 PST
(In reply to comment #2) > I forget whether run_command or run_and_throw_if_failed is preferred. > > @Eric? run_command.
Adam Barth
Comment 4 2011-12-05 16:06:50 PST
Comment on attachment 117593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117593&action=review > Tools/Scripts/webkitpy/common/system/executive.py:403 > + return_exit_code_and_output=False, Why not just catch the exception? That's what we usually do in these cases. The ScriptError has all the data.
Kentaro Hara
Comment 5 2011-12-05 18:09:59 PST
Created attachment 117972 [details] Patch
Adam Barth
Comment 6 2011-12-05 18:49:27 PST
Comment on attachment 117972 [details] Patch Thanks.
WebKit Review Bot
Comment 7 2011-12-06 00:05:29 PST
Comment on attachment 117972 [details] Patch Clearing flags on attachment: 117972 Committed r102105: <http://trac.webkit.org/changeset/102105>
WebKit Review Bot
Comment 8 2011-12-06 00:05:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.