Bug 73601

Summary: Make _build_path check more thoroughly that build paths exist.
Product: WebKit Reporter: Alice Boxhall <aboxhall>
Component: New BugsAssignee: Alice Boxhall <aboxhall>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alice Boxhall 2011-12-01 16:27:55 PST 
Make _build_path check more thoroughly that build paths exist.
Comment 1 Alice Boxhall 2011-12-01 16:28:44 PST 
Created attachment 117518 [details]
Patch
Comment 2 Ojan Vafai 2011-12-01 18:47:53 PST 
Comment on attachment 117518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173
> +            return self._filesystem.join(path)

This should just be "return path", right?
Comment 3 Alice Boxhall 2011-12-01 19:36:59 PST 
(In reply to comment #2)
> (From update of attachment 117518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173
> > +            return self._filesystem.join(path)
> 
> This should just be "return path", right?

Oops, of course.
Comment 4 Alice Boxhall 2011-12-01 19:40:14 PST 
Created attachment 117546 [details]
Patch
Comment 5 WebKit Review Bot 2011-12-02 10:47:33 PST 
Comment on attachment 117546 [details]
Patch

Clearing flags on attachment: 117546

Committed r101827: <http://trac.webkit.org/changeset/101827>
Comment 6 WebKit Review Bot 2011-12-02 10:47:38 PST 
All reviewed patches have been landed.  Closing bug.