Bug 73601

Summary:

Make _build_path check more thoroughly that build paths exist.

Product:

WebKit

Reporter:

Alice Boxhall <aboxhall>

Component:

New Bugs

Assignee:

Alice Boxhall <aboxhall>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Alice Boxhall

Reported 2011-12-01 16:27:55 PST

Make _build_path check more thoroughly that build paths exist.

Attachments
Patch (2.22 KB, patch) 2011-12-01 16:28 PST, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (2.20 KB, patch) 2011-12-01 19:40 PST, Alice Boxhall	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alice Boxhall

Comment 1 2011-12-01 16:28:44 PST

Ojan Vafai

Comment 2 2011-12-01 18:47:53 PST

Comment on attachment 117518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173 > + return self._filesystem.join(path) This should just be "return path", right?

Alice Boxhall

Comment 3 2011-12-01 19:36:59 PST

(In reply to comment #2) > (From update of attachment 117518 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173 > > + return self._filesystem.join(path) > > This should just be "return path", right? Oops, of course.

Alice Boxhall

Comment 4 2011-12-01 19:40:14 PST

WebKit Review Bot

Comment 5 2011-12-02 10:47:33 PST

WebKit Review Bot

Comment 6 2011-12-02 10:47:38 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.