Bug 73583

Summary: fullscreen/video-controls is too specific to the mac port
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
Patch
none
Patch eric.carlson: review+

Philippe Normand
Reported 2011-12-01 12:47:24 PST
The test on the height should be relaxed. Eric Carlson suggested to simply output the height value on the console and update the platform results.
Attachments
proposed patch (5.40 KB, patch)
2011-12-01 12:49 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (3.33 KB, patch)
2012-03-06 09:54 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2012-03-06 11:16 PST, Philippe Normand 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-12-01 12:49:44 PST
Created attachment 117462 [details] proposed patch
Darin Adler
Comment 2 2011-12-01 13:01:13 PST
Comment on attachment 117462 [details] proposed patch It’s normally important to have failure vs. success in a test. Is there anything we can do to make this a pass/fail test instead of one that logs the height?
Philippe Normand
Comment 3 2011-12-01 14:03:56 PST
Maybe we can test height >= 0. Would we reach concensus with this? :)
Philippe Normand
Comment 4 2012-03-06 01:45:37 PST
(In reply to comment #3) > Maybe we can test height >= 0. Would we reach concensus with this? :) I'm willing to update the test if Eric agrees with this.
Eric Carlson
Comment 5 2012-03-06 07:17:54 PST
"height >= 0" doesn't seem especially useful, can height ever be negative? I assume that a platform will have fullscreen controls if this test is now skipped, so how about testing that height is greater than a small but reasonable value (10?, 20?)?
Philippe Normand
Comment 6 2012-03-06 07:24:29 PST
(In reply to comment #5) > "height >= 0" doesn't seem especially useful, can height ever be negative? I assume that a platform will have fullscreen controls if this test is now skipped, so how about testing that height is greater than a small but reasonable value (10?, 20?)? Alright, 20 seems good enough to me. I'll update the patch!
Philippe Normand
Comment 7 2012-03-06 09:54:53 PST
Created attachment 130399 [details] Patch
WebKit Review Bot
Comment 8 2012-03-06 11:10:12 PST
Comment on attachment 130399 [details] Patch Attachment 130399 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11833497 New failing tests: fullscreen/video-controls-override.html
Philippe Normand
Comment 9 2012-03-06 11:16:06 PST
Created attachment 130415 [details] Patch
Philippe Normand
Comment 10 2012-03-06 23:46:48 PST
Committed r110025: <http://trac.webkit.org/changeset/110025>
Note You need to log in before you can comment on or make changes to this bug.