Bug 73581

Summary: Convert some fast/regions pixel tests to reftests
Product: WebKit Reporter: Jacob Goldstein <jacobg>
Component: Tools / TestsAssignee: Jacob Goldstein <jacobg>
Status: RESOLVED FIXED    
Severity: Normal CC: jacobg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jacob Goldstein
Reported 2011-12-01 12:24:17 PST
Convert some fast/regions pixel tests to reftests
Attachments
Patch (13.83 KB, patch)
2011-12-01 13:37 PST, Jacob Goldstein 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.75 KB, patch)
2011-12-01 16:19 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jacob Goldstein
Comment 1 2011-12-01 13:37:15 PST
Created attachment 117477 [details] Patch
Dave Hyatt
Comment 2 2011-12-01 14:45:51 PST
Comment on attachment 117477 [details] Patch r=me
WebKit Review Bot
Comment 3 2011-12-01 15:16:42 PST
Comment on attachment 117477 [details] Patch Rejecting attachment 117477 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: tains a binary file without the binary data in line: "Binary files a/LayoutTests/platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png and /dev/null differ". Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 667, <ARGV> line 185. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 9 Full output: http://queues.webkit.org/results/10701280
Tony Chang
Comment 4 2011-12-01 16:19:34 PST
Created attachment 117512 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-12-01 20:12:24 PST
Comment on attachment 117512 [details] Patch for landing Clearing flags on attachment: 117512 Committed r101738: <http://trac.webkit.org/changeset/101738>
WebKit Review Bot
Comment 6 2011-12-01 20:12:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.