Bug 73566

Summary: Web Inspector: Extract default call stack creation and check for front-end from console.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 73656    
Bug Blocks:    
Attachments:
Description Flags
Patch yurys: review+

Vsevolod Vlasov
Reported 2011-12-01 08:43:47 PST
Extract default call stack creation and check for front-end from console.
Attachments
Patch (15.02 KB, patch)
2011-12-01 08:51 PST, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-12-01 08:51:00 PST
Created attachment 117429 [details] Patch
Yury Semikhatsky
Comment 2 2011-12-02 06:46:27 PST
Comment on attachment 117429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117429&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:888 > + if (page && page->inspectorController()->hasFrontend()) return page && page->inspectorController()->hasFrontend(); > Source/WebCore/inspector/InspectorInstrumentation.cpp:894 > + if (workerInspectorController && workerInspectorController->hasFrontend()) return workerInspectorController && workerInspectorController->hasFrontend();
Vsevolod Vlasov
Comment 3 2011-12-02 07:24:21 PST
Committed r101794: <http://trac.webkit.org/changeset/101794>
Vsevolod Vlasov
Comment 4 2011-12-02 07:52:17 PST
Broke win build http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/42988/steps/compile-webkit/logs/stdio 3>c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\inspector\inspectorinstrumentation.cpp(897) : error C2220: warning treated as error - no 'object' file generated 3>c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\inspector\inspectorinstrumentation.cpp(897) : warning C4702: unreachable code rolled out: http://trac.webkit.org/changeset/101797
Vsevolod Vlasov
Comment 5 2011-12-07 06:01:10 PST
Committed r102233: <http://trac.webkit.org/changeset/102233>
Note You need to log in before you can comment on or make changes to this bug.