| Summary: | Web Inspector: Extract default call stack creation and check for front-end from console. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Vsevolod Vlasov <vsevik> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Vsevolod Vlasov <vsevik> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 73656 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Vsevolod Vlasov
2011-12-01 08:43:47 PST
Created attachment 117429 [details]
Patch
Comment on attachment 117429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117429&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:888 > + if (page && page->inspectorController()->hasFrontend()) return page && page->inspectorController()->hasFrontend(); > Source/WebCore/inspector/InspectorInstrumentation.cpp:894 > + if (workerInspectorController && workerInspectorController->hasFrontend()) return workerInspectorController && workerInspectorController->hasFrontend(); Committed r101794: <http://trac.webkit.org/changeset/101794> Broke win build http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/42988/steps/compile-webkit/logs/stdio 3>c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\inspector\inspectorinstrumentation.cpp(897) : error C2220: warning treated as error - no 'object' file generated 3>c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\inspector\inspectorinstrumentation.cpp(897) : warning C4702: unreachable code rolled out: http://trac.webkit.org/changeset/101797 Committed r102233: <http://trac.webkit.org/changeset/102233> |