Bug 73564

Summary: CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2011-12-01 08:08:37 PST
In this constructor:

- CSSMutableStyleDeclaration(CSSRule* parent, const CSSProperty* const * properties, int numProperties)

We do a hash lookup using contains(), followed by a get() if contains() returns true. This should be done with a single lookup.
Comment 1 Andreas Kling 2011-12-01 08:16:39 PST
Created attachment 117424 [details]
Patch
Comment 2 Antti Koivisto 2011-12-01 10:54:41 PST
Comment on attachment 117424 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-12-01 12:04:42 PST
Comment on attachment 117424 [details]
Patch

Clearing flags on attachment: 117424

Committed r101697: <http://trac.webkit.org/changeset/101697>
Comment 4 WebKit Review Bot 2011-12-01 12:04:47 PST
All reviewed patches have been landed.  Closing bug.