Bug 73556

Summary: Web Inspector: use object properties, not element attributes to pass preferred panel/line/request id in linkified anchors
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Andrey Kosyakov 2011-12-01 06:16:20 PST 
There used to be an inconsistent mix of HTML attributes and JS properties being used to associated additional data with an anchor element. This patch changes every linkifier to use object attributes. This also removes some duplicate linkifier code.
Comment 1 Andrey Kosyakov 2011-12-01 06:52:49 PST 
Created attachment 117412 [details]
Patch
Comment 2 Pavel Feldman 2011-12-01 08:59:47 PST 
Comment on attachment 117412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117412&action=review

> Source/WebCore/inspector/front-end/AuditFormatters.js:98
> +        return WebInspector.linkifyResourceAsNode(url, line - 1, "console-message-url webkit-html-resource-link");

Where is + 1?
Comment 3 Pavel Feldman 2011-12-01 09:04:35 PST 
Comment on attachment 117412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117412&action=review

>> Source/WebCore/inspector/front-end/AuditFormatters.js:98

> 
> Where is + 1?

I mean if extensions is the only subsystem using 1-based line numbers, we should limit its use to extensions.
Comment 4 Andrey Kosyakov 2011-12-01 09:20:16 PST 
(In reply to comment #3)
> (From update of attachment 117412 [details])
> > Where is + 1?
> 
> I mean if extensions is the only subsystem using 1-based line numbers, we should limit its use to extensions.

Done.
Comment 5 Andrey Kosyakov 2011-12-01 09:20:45 PST 
Created attachment 117435 [details]
Patch
Comment 6 Andrey Kosyakov 2011-12-02 01:06:53 PST 
Committed r101760: <http://trac.webkit.org/changeset/101760>