Bug 73542

Summary: Shadow ID pseudo-element selectors serialize incorrectly
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: CSSAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, dominicc, koivisto, macpherson, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72933    
Attachments:
Description Flags
Patch none

Description Roland Steiner 2011-12-01 02:14:43 PST
Shadow ID pseudo-elements add a whitespace between the host element part and the pseudo-element when being serialized. E.g.:

    #a::-webkit-slider-thumb

becomes

    #a ::webkit-slider-thumb

which has a different meaning.
Comment 1 Roland Steiner 2011-12-01 02:18:26 PST
Created attachment 117386 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-12-01 09:11:02 PST
Comment on attachment 117386 [details]
Patch

ooh, good catch. Thanks!
Comment 3 WebKit Review Bot 2011-12-01 09:47:41 PST
Comment on attachment 117386 [details]
Patch

Clearing flags on attachment: 117386

Committed r101679: <http://trac.webkit.org/changeset/101679>
Comment 4 WebKit Review Bot 2011-12-01 09:47:47 PST
All reviewed patches have been landed.  Closing bug.