Bug 73510 – New tests introduced in r101575 fail on all platform

• Component: HTML Editing
• Status: RESOLVED FIXED

[Hayato Ito]

The following layout test is failing on chromium port.

editing/deleting/delete-and-cleanup.html
editing/pasteboard/paste-without-nesting.html


Probable cause:
https://trac.webkit.org/changeset/101575

[Csaba Osztrogonác]

These new tests introduced in r101575 and fail on all platform: SL, GTK, Qt and Chromium.

--- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/editing/pasteboard/paste-without-nesting-expected.txt 
+++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/editing/pasteboard/paste-without-nesting-actual.txt 
@@ -1,11 +1,11 @@
 This test checks that copy a selection and paste over the same selection does not create nested divs.
 
-PASS confimedMarkup is 'Hello'
-PASS confimedMarkup is 'Hello<br>world'
-PASS confimedMarkup is '<div>Hello</div><div>world</div>'
-PASS confimedMarkup is '<div>Hello</div><div>world</div>'
-PASS confimedMarkup is '<div><b><i>Hello</i></b></div><div><b><i>world</i></b></div>'
-PASS confimedMarkup is '<div style="text-align: center;"><div><font color="#ff0000"><b><i>hello</i></b></font></div><div><font color="#ff0000"><b><i>world</i></b></font></div></div>'
+FAIL confimedMarkup should be Hello. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be Hello<br>world. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <div>Hello</div><div>world</div>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <div>Hello</div><div>world</div>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <div><b><i>Hello</i></b></div><div><b><i>world</i></b></div>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <div style="text-align: center;"><div><font color="#ff0000"><b><i>hello</i></b></font></div><div><font color="#ff0000"><b><i>world</i></b></font></div></div>. Threw exception ReferenceError: Can't find variable: confimedMarkup
 PASS successfullyParsed is true
 
 TEST COMPLETE



--- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/editing/deleting/delete-and-cleanup-expected.txt 
+++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/editing/deleting/delete-and-cleanup-actual.txt 
@@ -1,14 +1,14 @@
 This test checks that deletion does not leave unnecessary nested divs.
 
-PASS confimedMarkup is '<br>'
-PASS confimedMarkup is '<br>'
-PASS confimedMarkup is '<div id="mydiv"><br></div>'
-PASS confimedMarkup is '<br>'
-PASS confimedMarkup is '<b><i><br></i></b>'
-PASS confimedMarkup is '<b><div style="border: solid red"><i><br></i></div></b>'
-PASS confimedMarkup is '<br>'
-PASS confimedMarkup is '<br>'
-PASS confimedMarkup is '<p><br></p>'
+FAIL confimedMarkup should be <br>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <br>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <div id="mydiv"><br></div>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <br>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <b><i><br></i></b>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <b><div style="border: solid red"><i><br></i></div></b>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <br>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <br>. Threw exception ReferenceError: Can't find variable: confimedMarkup
+FAIL confimedMarkup should be <p><br></p>. Threw exception ReferenceError: Can't find variable: confimedMarkup
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryosuke Niwa]

Fixed the typo in http://trac.webkit.org/changeset/101622. Hopefully this would make the bots happy.

[Ryosuke Niwa]

Expected result fixed in http://trac.webkit.org/changeset/101629.

[Enrica Casucci]

(In reply to comment #3)
> Expected result fixed in http://trac.webkit.org/changeset/101629.

My apologies for the mistake.

[Enrica Casucci]

(In reply to comment #2)
> Fixed the typo in http://trac.webkit.org/changeset/101622. Hopefully this would make the bots happy.

Thanks for fixing it!

[Vsevolod Vlasov]

(In reply to comment #5)
> (In reply to comment #2)
> > Fixed the typo in http://trac.webkit.org/changeset/101622. Hopefully this would make the bots happy.
> 
> Thanks for fixing it!

Shouldn't this text be unfixed in test_expectations?
Looks like the bots are happy now!

[Vsevolod Vlasov]

I meant "these tests"