Bug 73506

Summary: Add WebLayer::setRootLayer
Product: WebKit Reporter: Scott Violet <sky>
Component: WebCore Misc.Assignee: Scott Violet <sky>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch 1 none

Scott Violet
Reported 2011-11-30 17:19:35 PST
There's a cycle between LayerChromium (m_layerTreeHost) and CCLayerTreeHost (m_rootLayer). We need to ability to break this cycle so the objects can be deleted. Adding a setRootLayer would allow for breaking the cycle.
Attachments
Patch 1 (2.40 KB, patch)
2011-11-30 17:42 PST, Scott Violet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Scott Violet
Comment 1 2011-11-30 17:42:49 PST
Created attachment 117305 [details] Patch 1
WebKit Review Bot
Comment 2 2011-11-30 17:46:19 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Antoine Labour
Comment 3 2011-11-30 18:12:35 PST
LGTM
James Robinson
Comment 4 2011-11-30 18:21:00 PST
Comment on attachment 117305 [details] Patch 1 R=me
WebKit Review Bot
Comment 5 2011-11-30 22:54:40 PST
Comment on attachment 117305 [details] Patch 1 Clearing flags on attachment: 117305 Committed r101613: <http://trac.webkit.org/changeset/101613>
WebKit Review Bot
Comment 6 2011-11-30 22:54:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.