Need to implement flex-flow: column-reverse

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Tony Chang]

It's not currently implemented.

I'm splitting this off from row reverse because it's considerably more complicated due to needing to repaint above the start of the box.

[Tony Chang]

Created attachment 117501 [details]
Patch

[Tony Chang]

Created attachment 117502 [details]
Patch

[Ojan Vafai]

Comment on attachment 117502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117502&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:635
> +        computeLogicalHeight();

If you move this out of the if-statement, you can remove the last computeLogicalHeight() call in layoutBlock(), right?

> Source/WebCore/rendering/RenderFlexibleBox.cpp:646
> +    // This is similar to the logic in layoutAndPlaceChildren, except we place the children
> +    // starting from the end of the flexbox. We also don't need to layout anything since we're
> +    // just moving the children to a new position.

Do we really need to duplicate all this logic? It is not sufficient to just flip the children?

[Tony Chang]

Created attachment 117685 [details]
Patch

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 117502 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117502&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:635
> > +        computeLogicalHeight();
> 
> If you move this out of the if-statement, you can remove the last computeLogicalHeight() call in layoutBlock(), right?

If we do that, then in the non-column-reverse case, we lose the overflow (clientLogicalBottom() will be called after we set the height to the computed height).

> > Source/WebCore/rendering/RenderFlexibleBox.cpp:646
> > +    // This is similar to the logic in layoutAndPlaceChildren, except we place the children
> > +    // starting from the end of the flexbox. We also don't need to layout anything since we're
> > +    // just moving the children to a new position.
> 
> Do we really need to duplicate all this logic? It is not sufficient to just flip the children?

It's a bit complicated because of how the padding and margins are applied. Based on offline discussion, I consolidated the flex-pack logic into some helper functions to cut down on duplicate code.

[Ojan Vafai]

Comment on attachment 117685 [details]
Patch

LGTM. I'll leave it for Hyatt to r+ though.

[Dave Hyatt]

Comment on attachment 117685 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 117685 [details]
Patch

Clearing flags on attachment: 117685

Committed r101897: <http://trac.webkit.org/changeset/101897>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.