Bug 73441 – [Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views.

• Component: New Bugs
• Status: RESOLVED FIXED

[alan]

[Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views.

[alan]

Created attachment 117184 [details]
Patch

[alan]

Kenneth, we've discussed marking the constraints with invalid flag, but it got me thinking whether it is different from the default value. Some constraints need to be applied no matter what and probably that should be the default constrains values. If we mark an instance with invalid flag, what values would the interaction engine be using across the code? The previously set or the default? The default values would fit perfectly with the current code which is exactly the same situation, when no values set yet on the interaction engine instance.
I am all for introducing the isValid flag, when the interaction engine code is ready/capable to use it. Let me know If i missed something

[Kenneth Rohde Christiansen]

Comment on attachment 117184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117184&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:211
> +    // Return default values for zero sized viewport.

Maybe add a comment that this will be ignored, ie. not applied

[WebKit Review Bot]

Comment on attachment 117184 [details]
Patch

Clearing flags on attachment: 117184

Committed r101763: <http://trac.webkit.org/changeset/101763>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.