Summary: | When playing audio in <video>, the poster is hidden on play | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeroen Wijering <mail> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://goo.gl/0g77d | ||||||
Attachments: |
|
Description
Jeroen Wijering
2011-11-30 00:06:11 PST
Safari on 10.7.2 behaves correctly. But Safari 5.1 on 10.6.8 does not, so it apparently depends on the media engine. We display the poster until HTMLVideoElement::hasAvailableVideoFrame returns true. That method asks the media engine if has video to display. The QTKit based method (MediaPlayerPrivateQTKit::hasAvailableVideoFrame) can't tell if a QTMovieLayer actually has frames ready to display, but it also doesn't check to see if the movie has video at all. This could be fixed in each of the media engines that have a problem (at least QTKit, QuickTime, and Chrome), or by adding one test to HTMLVideoElement. I am going to go with the later. Created attachment 117265 [details]
Proposed patch
Comment on attachment 117265 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=117265&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Bad to not have tests. Also can’t land the patch without removing the OOPS ;-) |