Bug 73368

Summary: toStringCallback and valueOfCallback do not check the entire prototype chain for convertToType callback
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Mark Hahnenberg
Reported 2011-11-29 15:05:27 PST
We need to check the entire chain, since the first JSClassRef may not be the one with the convertToType callback.
Attachments
Patch (3.67 KB, patch)
2011-11-29 15:07 PST, Mark Hahnenberg 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-29 15:07:46 PST
Created attachment 117054 [details] Patch
Mark Hahnenberg
Comment 2 2011-11-29 16:14:01 PST
<rdar://problem/10493218>
Darin Adler
Comment 3 2011-11-29 17:42:13 PST
Comment on attachment 117054 [details] Patch WebKit coding style requires more braces around those if statement bodies. We only omit them when the body is 1-line, not 1-statement-over-multiple-lines.
Mark Hahnenberg
Comment 4 2011-11-30 11:43:07 PST
Committed r101539: <http://trac.webkit.org/changeset/101539>
Note You need to log in before you can comment on or make changes to this bug.