Bug 73343

Summary: Clean up fast/regions/no-split-line-box.html test
Product: WebKit Reporter: Alan Stearns <stearns>
Component: Layout and RenderingAssignee: Alan Stearns <stearns>
Status: RESOLVED FIXED    
Severity: Minor CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
modify test, delete .pngs tony: review+

Alan Stearns
Reported 2011-11-29 11:26:34 PST
There are two errors in the test. The first is extra lines of text (which became an issue after the region-overflow property was added) and the second is that pixel snapshotting was erroneously turned on.
Attachments
modify test, delete .pngs (2.19 KB, patch)
2011-11-29 12:19 PST, Alan Stearns 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alan Stearns
Comment 1 2011-11-29 12:19:00 PST
Created attachment 117019 [details] modify test, delete .pngs
Tony Chang
Comment 2 2011-11-29 12:22:20 PST
Comment on attachment 117019 [details] modify test, delete .pngs The -expected.txt file doesn't change from the deleted text?
Alan Stearns
Comment 3 2011-11-29 12:27:09 PST
Nope - when the test runs in the test harness, all the content gets replaced with "PASS" if the javascript check succeeds. You only see the layout and test description if you run outside of the test harness.
Tony Chang
Comment 4 2011-11-29 13:12:02 PST
The patch doesn't apply (click on the purple boxes) so we can't cq the patch. I'll land manually for you.
Tony Chang
Comment 5 2011-11-29 13:31:54 PST
Committed r101417: <http://trac.webkit.org/changeset/101417>
Note You need to log in before you can comment on or make changes to this bug.