Bug 73336

Summary: Get rid of AllowCrossThreadAccess throughout ThreadableWebSocketChannelClientWrapper
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, levin, levin+threading, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 73290    
Bug Blocks: 67942    
Attachments:
Description Flags
Patch none

Takashi Toyoshima
Reported 2011-11-29 10:54:25 PST
We shouldn't use "AllowCrossThreadAccess" in ThreadableWebSocketChannelClientWrapper. Here's why: 1. It was added to highlight the places where we were not doing anything to help with lifetime of the object being passed. 2. At the time it was added, ThreadSafeRefCounted* objects passed through createCallbackTask did not have the ref count increased, so AllowCrossThreadAccess needed to be added here. 3. ThreadableWebSocketChannelClientWrapper is designed to be ref counted across threads -- largely to make sure that its lifetime is preserved by this call. This issue is derived from a review in https://bugs.webkit.org/show_bug.cgi?id=73290
Attachments
Patch (10.33 KB, patch)
2011-11-29 11:50 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-11-29 11:50:56 PST
Created attachment 117013 [details] Patch
David Levin
Comment 2 2011-11-29 11:52:36 PST
Comment on attachment 117013 [details] Patch Thanks!
Takashi Toyoshima
Comment 3 2011-11-29 11:57:24 PST
Thank YOU, too for good advice :-)
WebKit Review Bot
Comment 4 2011-11-30 18:33:53 PST
Comment on attachment 117013 [details] Patch Clearing flags on attachment: 117013 Committed r101583: <http://trac.webkit.org/changeset/101583>
WebKit Review Bot
Comment 5 2011-11-30 18:33:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.