Bug 73323

Summary:

Web Inspector: [refactoring] do not clone nodes that contain linkified URLs

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2011-11-29 07:54:03 PST

Avoid cloning nodes containing linkified URLs in StylesSidebatrPane. This is an intermediate step to use JS properties instead of "preferred_panel" and "line_number" attributes on linkified URLs.

Attachments
Patch (7.08 KB, patch) 2011-11-29 07:56 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (7.08 KB, patch) 2011-11-29 08:06 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (8.00 KB, patch) 2011-11-29 08:46 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (9.53 KB, patch) 2011-11-30 07:03 PST, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (9.41 KB, patch) 2011-11-30 07:14 PST, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2011-11-29 07:56:31 PST

Created attachment 116970 [details] Patch

Alexander Pavlov (apavlov)

Comment 2 2011-11-29 08:04:53 PST

Comment on attachment 116970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116970&action=review Looks good > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1132 > + this.identifier = identifier ; at the end lost

Andrey Kosyakov

Comment 3 2011-11-29 08:06:32 PST

Created attachment 116971 [details] Patch

Pavel Feldman

Comment 4 2011-11-29 08:09:33 PST

Comment on attachment 116970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116970&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-925 > - function linkifyUncopyable(url, line) Lets fix linkify uncopyable first.

Andrey Kosyakov

Comment 5 2011-11-29 08:46:30 PST

Created attachment 116977 [details] Patch

Pavel Feldman

Comment 6 2011-11-29 11:57:33 PST

Comment on attachment 116970 [details] Patch Cleaning r? that I have set accidentally.

Pavel Feldman

Comment 7 2011-11-30 01:52:25 PST

Comment on attachment 116977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116977&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-935 > - if (this.styleRule.sourceURL) Is there a reason behind the change of behavior? > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1124 > + _updateRuleOrigin: function(text) You don't need to update the origin. Extracting a method that would create a DOM elements link for given section is sufficient for getting rid of the clone.

Andrey Kosyakov

Comment 8 2011-11-30 07:03:59 PST

Created attachment 117186 [details] Patch

Andrey Kosyakov

Comment 9 2011-11-30 07:14:12 PST

Created attachment 117188 [details] Patch

Andrey Kosyakov

Comment 10 2011-11-30 07:15:56 PST

- dropped StylePropertiesSection.identifier - dropped updateOrigintText() - dropped url extraction from styleRule.rule

Andrey Kosyakov

Comment 11 2011-11-30 08:02:51 PST

Committed r101518: <http://trac.webkit.org/changeset/101518>

Note You need to log in before you can comment on or make changes to this bug.