Bug 73318 – [Qt][WK2] Implement experimental setDownloadsEnabled API

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Jesus Sanchez-Palencia]

We need an API for setting if downloads are enabled or not and if they will be handled or cancelled by the webview.

[Jesus Sanchez-Palencia]

Created attachment 116963 [details]
Patch

[Jesus Sanchez-Palencia]

Created attachment 117215 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 117215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117215&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebcontext.cpp:45
> +void QQuickWebContext::setDownloadsEnabled(bool enable)

wouldn't setDownloadEnabled make more sense? or setAllowDownloads()

[Simon Hausmann]

Comment on attachment 117215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117215&action=review

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:533
>      emit m_qmlWebView->experimental()->context()->downloadRequested(downloadItem);

I think this shows that there is something wrong with the placement of this code. The downloads are entirely context related, QtDownloadManager should cause the signal emission, it shouldn't have to be necessary to go all the way through the webview API, no?

[Simon Hausmann]

Comment on attachment 117215 [details]
Patch

r- because of the earlier comment that it seems that the view is the wrong place to handle such download related decisions. IMHO they belong into the context or a "sub object" of it instead, following the WK2 API intent of downloads being independent from the page and instead related to the context.

I guess bug #73364 will be defining this.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.