Bug 73315

Summary: [Qt] Make WebKit/qt build with V8 and Qt 5
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73312    
Attachments:
Description Flags
[Qt] Make WebKit/qt build with V8 and Qt 5 kenneth: review+

Simon Hausmann
Reported 2011-11-29 05:52:59 PST
[Qt] Make WebKit/qt build with V8 and Qt 5
Attachments
[Qt] Make WebKit/qt build with V8 and Qt 5 (12.38 KB, patch)
2011-11-29 05:57 PST, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-11-29 05:57:28 PST
Created attachment 116954 [details] [Qt] Make WebKit/qt build with V8 and Qt 5
Kenneth Rohde Christiansen
Comment 2 2011-11-29 06:06:06 PST
Comment on attachment 116954 [details] [Qt] Make WebKit/qt build with V8 and Qt 5 View in context: https://bugs.webkit.org/attachment.cgi?id=116954&action=review > Source/WebKit/qt/Api/qwebframe.cpp:697 > + QJSValue v = engine->newQObject(object); // ### ownership Why not use FIXME:?
Simon Hausmann
Comment 3 2011-11-29 06:38:16 PST
(In reply to comment #2) > (From update of attachment 116954 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116954&action=review > > > Source/WebKit/qt/Api/qwebframe.cpp:697 > > + QJSValue v = engine->newQObject(object); // ### ownership > > Why not use FIXME:? Good idea. Will do that.
Simon Hausmann
Comment 4 2011-11-29 06:40:08 PST
Committed r101366: <http://trac.webkit.org/changeset/101366>
Note You need to log in before you can comment on or make changes to this bug.