Summary: | [Chromium] [WebSocket] Add didUpdateBufferedAmount() callback to WebKit::WebSocketClient | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takashi Toyoshima <toyoshim> | ||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, fishd, tkent, webkit.review.bot, yutak | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 73290 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Takashi Toyoshima
2011-11-29 04:14:56 PST
Created attachment 116959 [details]
Patch
This change also depends a chromium side change.
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. FYI: Chromium side issue tracking is http://code.google.com/p/chromium/issues/detail?id=105708 Comment on attachment 116959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116959&action=review > Source/WebKit/chromium/public/WebSocketClient.h:50 > virtual void didReceiveMessage(const WebString& message) = 0; By the way, we have the convention of providing default implementations for all WebKit API methods that are intended to be implemented by the embedder. We don't use the OVERRIDE macro on the Chromium side. This is all done to minimize the pain of changing embedder implemented APIs. However, it has the drawback that the compiler will not tell you if you forget to implement a method. I think we have been happier reducing the amount of back-n-forth required to make WebKit API changes. So, please feel free to provide default implementations for these methods. Created attachment 117284 [details]
Patch for landing
Comment on attachment 116959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116959&action=review > Source/WebKit/chromium/public/WebSocketClient.h:53 > + virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) = 0; I see. I add default implementations and will remove OVERRIDE macro on the Chromium side. Comment on attachment 117284 [details] Patch for landing Rejecting attachment 117284 [details] from commit-queue. toyoshim@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 117284 [details]
Patch for landing
Oh, I could not use webkit-patch land-safely.
Could anyone who has committer right set it CQ+?
Comment on attachment 117284 [details] Patch for landing Clearing flags on attachment: 117284 Committed r101614: <http://trac.webkit.org/changeset/101614> All reviewed patches have been landed. Closing bug. |